OSDN Git Service
(root)
/
tomoyo
/
tomoyo-test1.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
d82d418
)
V4L/DVB (4991): Cafe_ccic.c: fix NULL dereference
author
Adrian Bunk
<bunk@stusta.de>
Wed, 20 Dec 2006 12:34:32 +0000
(09:34 -0300)
committer
Mauro Carvalho Chehab
<mchehab@infradead.org>
Wed, 27 Dec 2006 16:19:56 +0000
(14:19 -0200)
We shouldn't dereference "cam" when we already know it's NULL.
Spotted by the Coverity checker.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
drivers/media/video/cafe_ccic.c
patch
|
blob
|
history
diff --git
a/drivers/media/video/cafe_ccic.c
b/drivers/media/video/cafe_ccic.c
index
e347c7e
..
3083c80
100644
(file)
--- a/
drivers/media/video/cafe_ccic.c
+++ b/
drivers/media/video/cafe_ccic.c
@@
-2166,7
+2166,7
@@
static void cafe_pci_remove(struct pci_dev *pdev)
struct cafe_camera *cam = cafe_find_by_pdev(pdev);
if (cam == NULL) {
-
cam_warn(cam,
"pci_remove on unknown pdev %p\n", pdev);
+
printk(KERN_WARNING
"pci_remove on unknown pdev %p\n", pdev);
return;
}
mutex_lock(&cam->s_mutex);