OSDN Git Service

cifs: add check for returning value of SMB2_close_init
authorAnastasia Belova <abelova@astralinux.ru>
Tue, 15 Nov 2022 14:27:01 +0000 (17:27 +0300)
committerSteve French <stfrench@microsoft.com>
Tue, 15 Nov 2022 18:57:54 +0000 (12:57 -0600)
If the returning value of SMB2_close_init is an error-value,
exit the function.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: 352d96f3acc6 ("cifs: multichannel: move channel selection above transport layer")

Signed-off-by: Anastasia Belova <abelova@astralinux.ru>
Signed-off-by: Steve French <stfrench@microsoft.com>
fs/cifs/smb2ops.c

index 880cd49..9737296 100644 (file)
@@ -1126,6 +1126,8 @@ smb2_set_ea(const unsigned int xid, struct cifs_tcon *tcon,
        rqst[2].rq_nvec = 1;
        rc = SMB2_close_init(tcon, server,
                             &rqst[2], COMPOUND_FID, COMPOUND_FID, false);
+       if (rc)
+               goto sea_exit;
        smb2_set_related(&rqst[2]);
 
        rc = compound_send_recv(xid, ses, server,