OSDN Git Service

dpaa2-eth: make the array faf_bits static const, makes object smaller
authorColin Ian King <colin.king@canonical.com>
Sun, 1 Aug 2021 15:22:09 +0000 (16:22 +0100)
committerJakub Kicinski <kuba@kernel.org>
Mon, 2 Aug 2021 22:01:55 +0000 (15:01 -0700)
Don't populate the array faf_bits on the stack but instead it
static const. Makes the object code smaller by 175 bytes.

Before:
   text  data   bss     dec   hex filename
   9645  4552     0   14197  3775 ../freescale/dpaa2/dpaa2-eth-devlink.o

After:
   text  data   bss     dec   hex filename
   9406  4616     0   14022  36c6 ../freescale/dpaa2/dpaa2-eth-devlink.o

(gcc version 10.2.0)

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Link: https://lore.kernel.org/r/20210801152209.146359-1-colin.king@canonical.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/freescale/dpaa2/dpaa2-eth-devlink.c

index 8336962..8e09f65 100644 (file)
@@ -68,7 +68,7 @@ dpaa2_eth_dl_trap_item_lookup(struct dpaa2_eth_priv *priv, u16 trap_id)
 struct dpaa2_eth_trap_item *dpaa2_eth_dl_get_trap(struct dpaa2_eth_priv *priv,
                                                  struct dpaa2_fapr *fapr)
 {
-       struct dpaa2_faf_error_bit {
+       static const struct dpaa2_faf_error_bit {
                int position;
                enum devlink_trap_generic_id trap_id;
        } faf_bits[] = {