OSDN Git Service

mei: me: fix clang -Wformat warning
authorJustin Stitt <justinstitt@google.com>
Fri, 8 Jul 2022 20:35:49 +0000 (13:35 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 14 Jul 2022 14:53:38 +0000 (16:53 +0200)
When building with Clang we encounter the following warning:
| drivers/misc/mei/hw-me.c:564:44: error: format specifies type 'unsigned
| short' but the argument has type 'int' [-Werror,-Wformat]
| dev_dbg(dev->dev, "empty slots = %hu.\n", empty_slots);

The format specifier used is `%hu` which specifies an unsigned short,
however, empty_slots is an int -- hence the warning.

Link: https://github.com/ClangBuiltLinux/linux/issues/378
Tested-by: Nick Desaulniers <ndesaulniers@google.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Justin Stitt <justinstitt@google.com>
Link: https://lore.kernel.org/r/20220708203549.3834790-1-justinstitt@google.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/misc/mei/hw-me.c

index befa491..3a95fe7 100644 (file)
@@ -561,7 +561,7 @@ static int mei_me_hbuf_write(struct mei_device *dev,
        dev_dbg(dev->dev, MEI_HDR_FMT, MEI_HDR_PRM((struct mei_msg_hdr *)hdr));
 
        empty_slots = mei_hbuf_empty_slots(dev);
-       dev_dbg(dev->dev, "empty slots = %hu.\n", empty_slots);
+       dev_dbg(dev->dev, "empty slots = %d.\n", empty_slots);
 
        if (empty_slots < 0)
                return -EOVERFLOW;