OSDN Git Service

bus: fsl-mc: explicitly define the fsl_mc_command endianness
authorIoana Ciornei <ioana.ciornei@nxp.com>
Thu, 15 Nov 2018 12:12:12 +0000 (12:12 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 6 Dec 2018 14:53:15 +0000 (15:53 +0100)
Both the header and the command parameters of the fsl_mc_command are
64-bit little-endian words. Use the appropriate type to explicitly
specify their endianness.

Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com>
Reviewed-by: Laurentiu Tudor <laurentiu.tudor@nxp.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
include/linux/fsl/mc.h

index 9d3f668..741f567 100644 (file)
@@ -210,8 +210,8 @@ struct mc_cmd_header {
 };
 
 struct fsl_mc_command {
-       u64 header;
-       u64 params[MC_CMD_NUM_OF_PARAMS];
+       __le64 header;
+       __le64 params[MC_CMD_NUM_OF_PARAMS];
 };
 
 enum mc_cmd_status {
@@ -238,11 +238,11 @@ enum mc_cmd_status {
 /* Command completion flag */
 #define MC_CMD_FLAG_INTR_DIS   0x01
 
-static inline u64 mc_encode_cmd_header(u16 cmd_id,
-                                      u32 cmd_flags,
-                                      u16 token)
+static inline __le64 mc_encode_cmd_header(u16 cmd_id,
+                                         u32 cmd_flags,
+                                         u16 token)
 {
-       u64 header = 0;
+       __le64 header = 0;
        struct mc_cmd_header *hdr = (struct mc_cmd_header *)&header;
 
        hdr->cmd_id = cpu_to_le16(cmd_id);