OSDN Git Service

nfsd: simplify test_bit return in NFSD_FILE_KEY_FULL comparator
authorJeff Layton <jlayton@kernel.org>
Fri, 6 Jan 2023 15:39:01 +0000 (10:39 -0500)
committerChuck Lever <chuck.lever@oracle.com>
Wed, 26 Apr 2023 13:04:58 +0000 (09:04 -0400)
test_bit returns bool, so we can just compare the result of that to the
key->gc value without the "!!".

Signed-off-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
fs/nfsd/filecache.c

index c36e303..568963b 100644 (file)
@@ -189,7 +189,7 @@ static int nfsd_file_obj_cmpfn(struct rhashtable_compare_arg *arg,
                        return 1;
                if (!nfsd_match_cred(nf->nf_cred, key->cred))
                        return 1;
-               if (!!test_bit(NFSD_FILE_GC, &nf->nf_flags) != key->gc)
+               if (test_bit(NFSD_FILE_GC, &nf->nf_flags) != key->gc)
                        return 1;
                if (test_bit(NFSD_FILE_HASHED, &nf->nf_flags) == 0)
                        return 1;