OSDN Git Service

ieee802154: mcr20a: Replace magic number with constants
authorXue Liu <liuxuenetmail@gmail.com>
Fri, 31 Aug 2018 21:46:41 +0000 (23:46 +0200)
committerStefan Schmidt <stefan@datenfreihafen.org>
Thu, 27 Sep 2018 15:22:48 +0000 (17:22 +0200)
The combination of defined constants are used to present the
state of IRQ so the magic numbers has been replaced.

This is a simple coding style change which should have no impact on
runtime code execution.

Signed-off-by: Xue Liu <liuxuenetmail@gmail.com>
Signed-off-by: Stefan Schmidt <stefan@datenfreihafen.org>
drivers/net/ieee802154/mcr20a.c

index e428277..0489142 100644 (file)
@@ -903,19 +903,19 @@ mcr20a_irq_clean_complete(void *context)
 
        switch (seq_state) {
        /* TX IRQ, RX IRQ and SEQ IRQ */
-       case (0x03):
+       case (DAR_IRQSTS1_TXIRQ | DAR_IRQSTS1_SEQIRQ):
                if (lp->is_tx) {
                        lp->is_tx = 0;
                        dev_dbg(printdev(lp), "TX is done. No ACK\n");
                        mcr20a_handle_tx_complete(lp);
                }
                break;
-       case (0x05):
+       case (DAR_IRQSTS1_RXIRQ | DAR_IRQSTS1_SEQIRQ):
                        /* rx is starting */
                        dev_dbg(printdev(lp), "RX is starting\n");
                        mcr20a_handle_rx(lp);
                break;
-       case (0x07):
+       case (DAR_IRQSTS1_RXIRQ | DAR_IRQSTS1_TXIRQ | DAR_IRQSTS1_SEQIRQ):
                if (lp->is_tx) {
                        /* tx is done */
                        lp->is_tx = 0;
@@ -927,7 +927,7 @@ mcr20a_irq_clean_complete(void *context)
                        mcr20a_handle_rx(lp);
                }
                break;
-       case (0x01):
+       case (DAR_IRQSTS1_SEQIRQ):
                if (lp->is_tx) {
                        dev_dbg(printdev(lp), "TX is starting\n");
                        mcr20a_handle_tx(lp);