OSDN Git Service

staging: speakup: Remove unnecessary test in if condition
authorAmitoj Kaur Chawla <amitoj1606@gmail.com>
Wed, 24 Feb 2016 15:24:28 +0000 (20:54 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 5 Mar 2016 22:48:04 +0000 (14:48 -0800)
Remove unnecessary test on synth->alive since it has already been
tested previously.

This fixes the following smatch warning:
drivers/staging/speakup/synth.c:182 spk_synth_is_alive_restart() warn:
we tested 'synth->alive' before and it was 'false'

Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/speakup/synth.c

index 01eddab..4f462c3 100644 (file)
@@ -179,7 +179,7 @@ int spk_synth_is_alive_restart(struct spk_synth *synth)
 {
        if (synth->alive)
                return 1;
-       if (!synth->alive && spk_wait_for_xmitr() > 0) {
+       if (spk_wait_for_xmitr() > 0) {
                /* restart */
                synth->alive = 1;
                synth_printf("%s", synth->init);