OSDN Git Service

PM / OPP: Use snprintf() to avoid kasprintf() and kfree()
authorArvind Yadav <arvind.yadav.cs@gmail.com>
Thu, 21 Sep 2017 05:45:36 +0000 (11:15 +0530)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Tue, 10 Oct 2017 23:49:17 +0000 (01:49 +0200)
Use snprintf() to avoid unnecessary initializations, avoid calling
kfree().

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Reviewed-by: Stephen Boyd <sboyd@codeaurora.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/opp/debugfs.c

index 81cf120..9318848 100644 (file)
@@ -41,16 +41,15 @@ static bool opp_debug_create_supplies(struct dev_pm_opp *opp,
 {
        struct dentry *d;
        int i;
-       char *name;
 
        for (i = 0; i < opp_table->regulator_count; i++) {
-               name = kasprintf(GFP_KERNEL, "supply-%d", i);
+               char name[15];
+
+               snprintf(name, sizeof(name), "supply-%d", i);
 
                /* Create per-opp directory */
                d = debugfs_create_dir(name, pdentry);
 
-               kfree(name);
-
                if (!d)
                        return false;