OSDN Git Service

perf tests attr: Do not store failed events
authorJiri Olsa <jolsa@kernel.org>
Mon, 3 Jul 2017 14:50:17 +0000 (16:50 +0200)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Wed, 19 Jul 2017 02:14:14 +0000 (23:14 -0300)
Do not mess up our temp space with files we don't
need - failed event open attempts.

Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Cc: David Ahern <dsahern@gmail.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Thomas Richter <tmricht@linux.vnet.ibm.com>
Link: http://lkml.kernel.org/r/20170703145030.12903-3-jolsa@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/tests/attr.c

index 0e77b2c..08b1d5c 100644 (file)
@@ -136,7 +136,7 @@ void test_attr__open(struct perf_event_attr *attr, pid_t pid, int cpu,
 {
        int errno_saved = errno;
 
-       if (store_event(attr, pid, cpu, fd, group_fd, flags)) {
+       if ((fd != -1) && store_event(attr, pid, cpu, fd, group_fd, flags)) {
                pr_err("test attr FAILED");
                exit(128);
        }