OSDN Git Service

ALSA: lola: add a check for the return of vmalloc()
authorXiaoke Wang <xkernel.wang@foxmail.com>
Fri, 4 Mar 2022 08:38:20 +0000 (16:38 +0800)
committerTakashi Iwai <tiwai@suse.de>
Fri, 4 Mar 2022 08:51:37 +0000 (09:51 +0100)
vmalloc() is a memory allocation function which can return NULL when
some internal memory errors happen. So it is better to check the return
of it to catch the error in time.

Signed-off-by: Xiaoke Wang <xkernel.wang@foxmail.com>
Link: https://lore.kernel.org/r/tencent_4221FC4089F6DF01C48F192E5784038BA205@qq.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/lola/lola_mixer.c

index e2c8f14..6b16248 100644 (file)
@@ -121,6 +121,8 @@ int lola_init_mixer_widget(struct lola *chip, int nid)
 
        /* reserve memory to copy mixer data for sleep mode transitions */
        chip->mixer.array_saved = vmalloc(sizeof(struct lola_mixer_array));
+       if (!chip->mixer.array_saved)
+               return -ENOMEM;
 
        /* mixer matrix sources are physical input data and play streams */
        chip->mixer.src_stream_outs = chip->pcm[PLAY].num_streams;