OSDN Git Service

net: jme: Replace mdelay() with msleep() and usleep_range() in jme_wait_link()
authorJia-Ju Bai <baijiaju1990@gmail.com>
Fri, 27 Jul 2018 08:25:07 +0000 (16:25 +0800)
committerDavid S. Miller <davem@davemloft.net>
Fri, 27 Jul 2018 20:45:14 +0000 (13:45 -0700)
jme_wait_link() is never called in atomic context.
It calls mdelay() to busily wait, which is not necessary.
mdelay() can be replaced with msleep() and usleep_range().

This is found by a static analysis tool named DCNS written by myself.

Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/jme.c

index 06ff185..a5ab6f3 100644 (file)
@@ -1911,10 +1911,10 @@ jme_wait_link(struct jme_adapter *jme)
 {
        u32 phylink, to = JME_WAIT_LINK_TIME;
 
-       mdelay(1000);
+       msleep(1000);
        phylink = jme_linkstat_from_phy(jme);
        while (!(phylink & PHY_LINK_UP) && (to -= 10) > 0) {
-               mdelay(10);
+               usleep_range(10000, 11000);
                phylink = jme_linkstat_from_phy(jme);
        }
 }