OSDN Git Service

crypto: ccree - Simplify with dev_err_probe()
authorKrzysztof Kozlowski <krzk@kernel.org>
Wed, 26 Aug 2020 16:29:54 +0000 (18:29 +0200)
committerHerbert Xu <herbert@gondor.apana.org.au>
Fri, 4 Sep 2020 07:57:16 +0000 (17:57 +1000)
Common pattern of handling deferred probe can be simplified with
dev_err_probe().  Less code and also it prints the error value.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/ccree/cc_driver.c

index 2d50991..6f519d3 100644 (file)
@@ -300,11 +300,8 @@ static int init_cc_resources(struct platform_device *plat_dev)
        new_drvdata->plat_dev = plat_dev;
 
        clk = devm_clk_get_optional(dev, NULL);
-       if (IS_ERR(clk)) {
-               if (PTR_ERR(clk) != -EPROBE_DEFER)
-                       dev_err(dev, "Error getting clock: %pe\n", clk);
-               return PTR_ERR(clk);
-       }
+       if (IS_ERR(clk))
+               return dev_err_probe(dev, PTR_ERR(clk), "Error getting clock\n");
        new_drvdata->clk = clk;
 
        new_drvdata->coherent = of_dma_is_coherent(np);