OSDN Git Service

rtlwifi: rtl_pci: fix bool comparison in expressions
authorAditya Srivastava <yashsri421@gmail.com>
Sun, 10 Jan 2021 12:15:21 +0000 (17:45 +0530)
committerKalle Valo <kvalo@codeaurora.org>
Mon, 25 Jan 2021 14:21:01 +0000 (16:21 +0200)
There are certain conditional expressions in rtl_pci, where a boolean
variable is compared with true/false, in forms such as (foo == true) or
(false != bar), which does not comply with checkpatch.pl (CHECK:
BOOL_COMPARISON), according to which boolean variables should be
themselves used in the condition, rather than comparing with true/false

E.g., in drivers/net/wireless/realtek/rtlwifi/ps.c,
"if (find_p2p_ie == true)" can be replaced with "if (find_p2p_ie)"

Replace all such expressions with the bool variables appropriately

Signed-off-by: Aditya Srivastava <yashsri421@gmail.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20210110121525.2407-2-yashsri421@gmail.com
drivers/net/wireless/realtek/rtlwifi/ps.c

index f998822..629c032 100644 (file)
@@ -798,9 +798,9 @@ static void rtl_p2p_noa_ie(struct ieee80211_hw *hw, void *data,
                ie += 3 + noa_len;
        }
 
-       if (find_p2p_ie == true) {
+       if (find_p2p_ie) {
                if ((p2pinfo->p2p_ps_mode > P2P_PS_NONE) &&
-                   (find_p2p_ps_ie == false))
+                   (!find_p2p_ps_ie))
                        rtl_p2p_ps_cmd(hw, P2P_PS_DISABLE);
        }
 }