OSDN Git Service

cnic: remove redundant assignment to variable ret
authorColin Ian King <colin.king@canonical.com>
Fri, 8 May 2020 22:40:26 +0000 (23:40 +0100)
committerJakub Kicinski <kuba@kernel.org>
Sat, 9 May 2020 05:46:16 +0000 (22:46 -0700)
The variable ret is being assigned with a value that is never read,
the assignment is redundant and can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Michael Chan <michael.chan@broadcom.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/broadcom/cnic.c

index 61ab7d2..c5cca63 100644 (file)
@@ -1918,7 +1918,6 @@ static int cnic_bnx2x_iscsi_ofld1(struct cnic_dev *dev, struct kwqe *wqes[],
        ret = cnic_alloc_bnx2x_conn_resc(dev, l5_cid);
        if (ret) {
                atomic_dec(&cp->iscsi_conn);
-               ret = 0;
                goto done;
        }
        ret = cnic_setup_bnx2x_ctx(dev, wqes, num);