OSDN Git Service

ALSA: oxfw: allow PCM capture for Stanton SCS.1m
authorTakashi Sakamoto <o-takashi@sakamocchi.jp>
Sun, 9 Jun 2019 10:29:12 +0000 (19:29 +0900)
committerTakashi Iwai <tiwai@suse.de>
Tue, 11 Jun 2019 09:48:10 +0000 (11:48 +0200)
Stanton SCS.1m can transfer isochronous packet with Multi Bit Linear
Audio data channels, therefore it allows software to capture PCM
substream. However, ALSA oxfw driver doesn't.

This commit changes the driver to add one PCM substream for capture
direction.

Fixes: de5126cc3c0b ("ALSA: oxfw: add stream format quirk for SCS.1 models")
Cc: <stable@vger.kernel.org> # v4.5+
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/firewire/oxfw/oxfw.c

index 3d27f33..b4bef57 100644 (file)
@@ -148,9 +148,6 @@ static int detect_quirks(struct snd_oxfw *oxfw)
                oxfw->midi_input_ports = 0;
                oxfw->midi_output_ports = 0;
 
-               /* Output stream exists but no data channels are useful. */
-               oxfw->has_output = false;
-
                return snd_oxfw_scs1x_add(oxfw);
        }