OSDN Git Service

drm/i915: Program i830 DPLL FP register later
authorVille Syrjälä <ville.syrjala@linux.intel.com>
Mon, 21 Mar 2022 19:50:04 +0000 (21:50 +0200)
committerVille Syrjälä <ville.syrjala@linux.intel.com>
Wed, 20 Apr 2022 13:56:11 +0000 (16:56 +0300)
Follow the new i9xx DPLL FP register programming sequence
introduced in commit 62d66b218386 ("drm/i915: Fold
i9xx_set_pll_dividers() into i9xx_enable_pll()") in the
i830 "power well" code as well. Just for consistency.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20220321195006.775-2-ville.syrjala@linux.intel.com
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
drivers/gpu/drm/i915/display/intel_display.c

index 29044cf..fc5c091 100644 (file)
@@ -9844,9 +9844,6 @@ void i830_enable_pipe(struct drm_i915_private *dev_priv, enum pipe pipe)
                PLL_REF_INPUT_DREFCLK |
                DPLL_VCO_ENABLE;
 
-       intel_de_write(dev_priv, FP0(pipe), fp);
-       intel_de_write(dev_priv, FP1(pipe), fp);
-
        intel_de_write(dev_priv, HTOTAL(pipe), (640 - 1) | ((800 - 1) << 16));
        intel_de_write(dev_priv, HBLANK(pipe), (640 - 1) | ((800 - 1) << 16));
        intel_de_write(dev_priv, HSYNC(pipe), (656 - 1) | ((752 - 1) << 16));
@@ -9855,6 +9852,9 @@ void i830_enable_pipe(struct drm_i915_private *dev_priv, enum pipe pipe)
        intel_de_write(dev_priv, VSYNC(pipe), (490 - 1) | ((492 - 1) << 16));
        intel_de_write(dev_priv, PIPESRC(pipe), ((640 - 1) << 16) | (480 - 1));
 
+       intel_de_write(dev_priv, FP0(pipe), fp);
+       intel_de_write(dev_priv, FP1(pipe), fp);
+
        /*
         * Apparently we need to have VGA mode enabled prior to changing
         * the P1/P2 dividers. Otherwise the DPLL will keep using the old