Cppcheck: CWE: 398: Class '...' has a constructor with 1 argument that is not explici...

diff --git a/Src/Common/IniOptionsMgr.h b/Src/Common/IniOptionsMgr.h
index bb85c97..45197e9 100644 (file)
--- a/Src/Common/IniOptionsMgr.h
+++ b/Src/Common/IniOptionsMgr.h
@@ -17,7 +17,7 @@ class COptionsMgr;
 class CIniOptionsMgr : public COptionsMgr
 {
 public:
-       CIniOptionsMgr(const String& filePath);
+       explicit CIniOptionsMgr(const String& filePath);
        virtual ~CIniOptionsMgr();
 
        virtual int InitOption(const String& name, const varprop::VariantValue& defaultValue) override;

diff --git a/Src/Common/memdc.h b/Src/Common/memdc.h
index 9623a53..9a53878 100644 (file)
--- a/Src/Common/memdc.h
+++ b/Src/Common/memdc.h
@@ -34,7 +34,7 @@ private:
        bool            m_bMemDC;               // `true` if CDC really is a Memory DC.
 public:
        
-       CMyMemDC(CDC* pDC, const CRect* pRect = nullptr) : CDC()
+       explicit CMyMemDC(CDC* pDC, const CRect* pRect = nullptr) : CDC()
        {
                ASSERT(pDC != nullptr); 
 

diff --git a/Src/Concurrent.h b/Src/Concurrent.h
index a2d73a0..ba39537 100644 (file)
--- a/Src/Concurrent.h
+++ b/Src/Concurrent.h
@@ -16,7 +16,7 @@ namespace Concurrent
                        bool m_completed;
                };
 
-               Task(TaskParams *pParams) : m_pParams(pParams)
+               explicit Task(TaskParams *pParams) : m_pParams(pParams)
                {
                }