OSDN Git Service

phy: qcom-qusb2: fix missing assignment of ret when calling clk_prepare_enable
authorColin Ian King <colin.king@canonical.com>
Fri, 31 May 2019 12:05:59 +0000 (13:05 +0100)
committerKishon Vijay Abraham I <kishon@ti.com>
Mon, 3 Jun 2019 11:33:52 +0000 (17:03 +0530)
The error return from the call to clk_prepare_enable is not being assigned
to variable ret even though ret is being used to check if the call failed.
Fix this by adding in the missing assignment.

Addresses-Coverity: ("Logically dead code")
Fixes: 891a96f65ac3 ("phy: qcom-qusb2: Add support for runtime PM")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
drivers/phy/qualcomm/phy-qcom-qusb2.c

index 1cbf1d6..bf94a52 100644 (file)
@@ -564,7 +564,7 @@ static int __maybe_unused qusb2_phy_runtime_resume(struct device *dev)
        }
 
        if (!qphy->has_se_clk_scheme) {
-               clk_prepare_enable(qphy->ref_clk);
+               ret = clk_prepare_enable(qphy->ref_clk);
                if (ret) {
                        dev_err(dev, "failed to enable ref clk, %d\n", ret);
                        goto disable_ahb_clk;