Improve AlbumSet UI in new gallery

Change-Id: I31cbf7cf8c0c7b5f5f3413a59ad94142b13870d2

diff --git a/res/layout/album_set.xml b/res/layout/album_set.xml
index 5ff1d23..5e2e848 100644 (file)
--- a/res/layout/album_set.xml
+++ b/res/layout/album_set.xml
@@ -12,9 +12,11 @@
         android:columnWidth="@dimen/album_set_item_width"
         android:stretchMode="columnWidth"
         android:drawSelectorOnTop="true"
-        android:padding="10dp"
-        android:horizontalSpacing="10dp"
-        android:verticalSpacing="10dp" />
+        android:background="#E5E5E5"
+        android:paddingLeft="10dp"
+        android:paddingRight="10dp"
+        android:horizontalSpacing="6dp"
+        android:verticalSpacing="6dp" />
 
     <TextView
         android:id="@id/android:empty"

diff --git a/res/layout/album_set_item.xml b/res/layout/album_set_item.xml
index bdecd5f..ad0e0db 100644 (file)
--- a/res/layout/album_set_item.xml
+++ b/res/layout/album_set_item.xml
@@ -1,42 +1,39 @@
 <?xml version="1.0" encoding="utf-8"?>
-<RelativeLayout xmlns:android="http://schemas.android.com/apk/res/android"
+<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
     android:layout_height="wrap_content"
     android:layout_width="match_parent"
-    android:background="#FFF" >
+    android:orientation="vertical"
+    android:background="?android:attr/activatedBackgroundIndicator"
+    android:padding="2dp" >
 
-    <TextView
-        android:id="@+id/album_set_item_title"
-        android:layout_width="wrap_content"
+    <LinearLayout
         android:layout_height="wrap_content"
-        android:layout_alignParentLeft="true"
-        android:layout_alignParentTop="true"
-        android:layout_marginLeft="10dp"
-        android:layout_marginTop="10dp"
-        android:ellipsize="end"
-        android:singleLine="true"
-        android:textAppearance="?android:attr/textAppearanceMedium" />
+        android:layout_width="match_parent"
+        android:orientation="vertical"
+        android:padding="10dp"
+        android:background="#FFF" >
 
-    <TextView
-        android:id="@+id/album_set_item_date"
-        android:layout_width="wrap_content"
-        android:layout_height="wrap_content"
-        android:layout_alignLeft="@+id/album_set_item_title"
-        android:layout_below="@+id/album_set_item_title"
-        android:layout_marginBottom="10dp"
-        android:textAppearance="?android:attr/textAppearanceSmall" />
+        <TextView
+            android:id="@+id/album_set_item_title"
+            android:layout_width="wrap_content"
+            android:layout_height="wrap_content"
+            android:ellipsize="end"
+            android:singleLine="true"
+            android:textAppearance="?android:attr/textAppearanceMedium" />
+
+        <TextView
+            android:id="@+id/album_set_item_count"
+            android:layout_width="wrap_content"
+            android:layout_height="wrap_content"
+            android:ellipsize="end"
+            android:singleLine="true"
+            android:textAppearance="?android:attr/textAppearanceSmall"
+            android:textColor="#AAA" />
+    </LinearLayout>
 
     <ImageView
         android:id="@+id/album_set_item_image"
         android:layout_width="match_parent"
         android:layout_height="@dimen/album_set_item_image_height"
-        android:layout_below="@+id/album_set_item_date"
         android:scaleType="centerCrop" />
-
-    <ProgressBar
-        android:id="@+id/album_set_item_upload_progress"
-        style="?android:attr/progressBarStyleHorizontal"
-        android:layout_width="match_parent"
-        android:layout_height="wrap_content"
-        android:visibility="invisible"
-        android:layout_alignParentBottom="true" />
-</RelativeLayout>
\ No newline at end of file
+</LinearLayout>
\ No newline at end of file

diff --git a/res/values/dimensions.xml b/res/values/dimensions.xml
index 9ef192c..aba596f 100644 (file)
--- a/res/values/dimensions.xml
+++ b/res/values/dimensions.xml
@@ -52,6 +52,6 @@
     <dimen name="thumbnail_margin">3dip</dimen>
 
     <!-- configuration for album set page -->
-    <dimen name="album_set_item_image_height">100dp</dimen>
+    <dimen name="album_set_item_image_height">120dp</dimen>
     <dimen name="album_set_item_width">140dp</dimen>
 </resources>

diff --git a/res/values/strings.xml b/res/values/strings.xml
index 263b8b1..6e35bfc 100644 (file)
--- a/res/values/strings.xml
+++ b/res/values/strings.xml
@@ -1010,4 +1010,10 @@ CHAR LIMIT = NONE] -->
     <string name="tab_photos">Photos</string>
     <!-- Title for the albums tab [CHAR LIMIT=25] -->
     <string name="tab_albums">Albums</string>
+
+    <!-- String indicating how many photos are in an album [CHAR LIMIT=15] -->
+    <plurals name="number_of_photos">
+        <item quantity="one">%1$d photo</item>
+        <item quantity="other">%1$d photos</item>
+    </plurals>
 </resources>

diff --git a/src/com/android/photos/adapters/AlbumSetCursorAdapter.java b/src/com/android/photos/adapters/AlbumSetCursorAdapter.java
index c387f8f..ab99cde 100644 (file)
--- a/src/com/android/photos/adapters/AlbumSetCursorAdapter.java
+++ b/src/com/android/photos/adapters/AlbumSetCursorAdapter.java
@@ -41,7 +41,6 @@ public class AlbumSetCursorAdapter extends CursorAdapter {
     public void setDrawableFactory(LoaderCompatShim<Cursor> factory) {
         mDrawableFactory = factory;
     }
-    private Date mDate = new Date(); // Used for converting timestamps for display
 
     public AlbumSetCursorAdapter(Context context) {
         super(context, null, false);
@@ -53,24 +52,11 @@ public class AlbumSetCursorAdapter extends CursorAdapter {
                 R.id.album_set_item_title);
         titleTextView.setText(cursor.getString(AlbumSetLoader.INDEX_TITLE));
 
-        TextView dateTextView = (TextView) v.findViewById(
-                R.id.album_set_item_date);
-        long timestamp = cursor.getLong(AlbumSetLoader.INDEX_TIMESTAMP);
-        if (timestamp > 0) {
-            mDate.setTime(timestamp);
-            dateTextView.setText(DateFormat.getMediumDateFormat(context).format(mDate));
-        } else {
-            dateTextView.setText(null);
-        }
-
-        ProgressBar uploadProgressBar = (ProgressBar) v.findViewById(
-                R.id.album_set_item_upload_progress);
-        if (cursor.getInt(AlbumSetLoader.INDEX_COUNT_PENDING_UPLOAD) > 0) {
-            uploadProgressBar.setVisibility(View.VISIBLE);
-            uploadProgressBar.setProgress(50);
-        } else {
-            uploadProgressBar.setVisibility(View.INVISIBLE);
-        }
+        TextView countTextView = (TextView) v.findViewById(
+                R.id.album_set_item_count);
+        int count = cursor.getInt(AlbumSetLoader.INDEX_COUNT);
+        countTextView.setText(context.getResources().getQuantityString(
+                R.plurals.number_of_photos, count, count));
 
         ImageView thumbImageView = (ImageView) v.findViewById(
                 R.id.album_set_item_image);