OSDN Git Service

drm/msm/dpu: replace BIT(x) with correspond marco define string
authorKuogee Hsieh <quic_khsieh@quicinc.com>
Fri, 25 Feb 2022 21:23:10 +0000 (13:23 -0800)
committerDmitry Baryshkov <dmitry.baryshkov@linaro.org>
Mon, 25 Apr 2022 21:50:47 +0000 (00:50 +0300)
To improve code readability, this patch replace BIT(x) with
correspond register bit define string

Signed-off-by: Kuogee Hsieh <quic_khsieh@quicinc.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
Patchwork: https://patchwork.freedesktop.org/patch/476280/
Link: https://lore.kernel.org/r/1645824192-29670-3-git-send-email-quic_khsieh@quicinc.com
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.c

index 284f561..c2cd185 100644 (file)
 
 #define   INTF_MUX                      0x25C
 
+#define INTF_CFG_ACTIVE_H_EN   BIT(29)
+#define INTF_CFG_ACTIVE_V_EN   BIT(30)
+
+#define INTF_CFG2_DATABUS_WIDEN        BIT(0)
+#define INTF_CFG2_DATA_HCTL_EN BIT(4)
+
 static const struct dpu_intf_cfg *_intf_offset(enum dpu_intf intf,
                const struct dpu_mdss_cfg *m,
                void __iomem *addr,
@@ -130,13 +136,13 @@ static void dpu_hw_intf_setup_timing_engine(struct dpu_hw_intf *ctx,
 
        if (active_h_end) {
                active_hctl = (active_h_end << 16) | active_h_start;
-               intf_cfg |= BIT(29);    /* ACTIVE_H_ENABLE */
+               intf_cfg |= INTF_CFG_ACTIVE_H_EN;
        } else {
                active_hctl = 0;
        }
 
        if (active_v_end)
-               intf_cfg |= BIT(30); /* ACTIVE_V_ENABLE */
+               intf_cfg |= INTF_CFG_ACTIVE_V_EN;
 
        hsync_ctl = (hsync_period << 16) | p->hsync_pulse_width;
        display_hctl = (hsync_end_x << 16) | hsync_start_x;
@@ -182,7 +188,7 @@ static void dpu_hw_intf_setup_timing_engine(struct dpu_hw_intf *ctx,
                                (0x21 << 8));
 
        if (ctx->cap->features & BIT(DPU_DATA_HCTL_EN)) {
-               intf_cfg2 |= BIT(4);
+               intf_cfg2 |= INTF_CFG2_DATA_HCTL_EN;
                display_data_hctl = display_hctl;
                DPU_REG_WRITE(c, INTF_CONFIG2, intf_cfg2);
                DPU_REG_WRITE(c, INTF_DISPLAY_DATA_HCTL, display_data_hctl);