OSDN Git Service

powerpc: unrel_branch_check.sh: fix shellcheck complaints
authorStephen Rothwell <sfr@canb.auug.org.au>
Tue, 11 Aug 2020 14:04:28 +0000 (00:04 +1000)
committerMichael Ellerman <mpe@ellerman.id.au>
Wed, 2 Sep 2020 01:00:21 +0000 (11:00 +1000)
No functional change

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20200811140435.20957-2-sfr@canb.auug.org.au
arch/powerpc/tools/unrel_branch_check.sh

index 6e6a30a..4c1e04b 100755 (executable)
@@ -1,3 +1,4 @@
+#!/bin/bash
 # Copyright © 2016 IBM Corporation
 #
 # This program is free software; you can redistribute it and/or
@@ -26,7 +27,7 @@ awk '{print $1}'
 
 BRANCHES=$(
 $objdump -R "$vmlinux" -D --start-address=0xc000000000000000           \
-               --stop-address=${end_intr} |
+               --stop-address="$end_intr" |
 grep -e "^c[0-9a-f]*:[[:space:]]*\([0-9a-f][0-9a-f][[:space:]]\)\{4\}[[:space:]]*b" |
 grep -v '\<__start_initialization_multiplatform>' |
 grep -v -e 'b.\?.\?ctr' |
@@ -40,12 +41,12 @@ awk '{ print $1 ":" $6 ":0x" $7 ":" $8 " "}'
 
 for tuple in $BRANCHES
 do
-       from=`echo $tuple | cut -d':' -f1`
-       branch=`echo $tuple | cut -d':' -f2`
-       to=`echo $tuple | cut -d':' -f3 | sed 's/cr[0-7],//'`
-       sym=`echo $tuple | cut -d':' -f4`
+       from=$(echo "$tuple" | cut -d':' -f1)
+       branch=$(echo "$tuple" | cut -d':' -f2)
+       to=$(echo "$tuple" | cut -d':' -f3 | sed 's/cr[0-7],//')
+       sym=$(echo "$tuple" | cut -d':' -f4)
 
-       if (( $to > $end_intr ))
+       if (( to > end_intr ))
        then
                if [ -z "$bad_branches" ]; then
                        echo "WARNING: Unrelocated relative branches"