OSDN Git Service

staging:iio:max1363: Do not return error code in interrupt handler
authorLars-Peter Clausen <lars@metafoo.de>
Wed, 4 Jul 2012 16:09:00 +0000 (17:09 +0100)
committerJonathan Cameron <jic23@kernel.org>
Sun, 8 Jul 2012 19:02:29 +0000 (20:02 +0100)
The interrupt handler should only ever return one of the three irqreturn_t
constants and not an error code. Also make sure to always call
iio_trigger_notify_done before leaving the trigger handler.

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
drivers/staging/iio/adc/max1363_ring.c

index b302013..bf6b0c2 100644 (file)
@@ -64,11 +64,11 @@ static irqreturn_t max1363_trigger_handler(int irq, void *p)
         * no harm.
         */
        if (numvals == 0)
-               return IRQ_HANDLED;
+               goto done;
 
        rxbuf = kmalloc(d_size, GFP_KERNEL);
        if (rxbuf == NULL)
-               return -ENOMEM;
+               goto done;
        if (st->chip_info->bits != 8)
                b_sent = i2c_master_recv(st->client, rxbuf, numvals*2);
        else