OSDN Git Service

mwifiex: make arrays static const, makes object smaller
authorColin Ian King <colin.king@canonical.com>
Thu, 19 Aug 2021 12:16:51 +0000 (13:16 +0100)
committerKalle Valo <kvalo@codeaurora.org>
Sat, 21 Aug 2021 17:50:23 +0000 (20:50 +0300)
Don't populate the arrays wpa_oui and wps_oui on the stack but
instead them static const. Makes the object code smaller by 63 bytes:

Before:
   text   data  bss     dec    hex filename
  29453   5451   64   34968   8898 .../wireless/marvell/mwifiex/sta_ioctl.o

After:
   text   data  bss     dec    hex filename
  29356   5611   64   35031   88d7 ../wireless/marvell/mwifiex/sta_ioctl.o

(gcc version 10.3.0)

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20210819121651.7566-1-colin.king@canonical.com
drivers/net/wireless/marvell/mwifiex/sta_ioctl.c

index 653f9e0..4062e51 100644 (file)
@@ -1325,8 +1325,8 @@ mwifiex_set_gen_ie_helper(struct mwifiex_private *priv, u8 *ie_data_ptr,
                          u16 ie_len)
 {
        struct ieee_types_vendor_header *pvendor_ie;
-       const u8 wpa_oui[] = { 0x00, 0x50, 0xf2, 0x01 };
-       const u8 wps_oui[] = { 0x00, 0x50, 0xf2, 0x04 };
+       static const u8 wpa_oui[] = { 0x00, 0x50, 0xf2, 0x01 };
+       static const u8 wps_oui[] = { 0x00, 0x50, 0xf2, 0x04 };
        u16 unparsed_len = ie_len, cur_ie_len;
 
        /* If the passed length is zero, reset the buffer */