OSDN Git Service

ACPI: SPCR: Prefix error messages with FW_BUG
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Wed, 22 Mar 2023 10:22:57 +0000 (12:22 +0200)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Wed, 22 Mar 2023 18:46:49 +0000 (19:46 +0100)
The table values that are not defined in the specification are
considered non-fatal errors in the code.

However, they are firmware bugs, so point this out in the messages by
prefixing them with FW_BUG.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/acpi/spcr.c

index 1eabfcd..01d29eb 100644 (file)
@@ -110,12 +110,12 @@ int __init acpi_parse_spcr(bool enable_earlycon, bool enable_console)
                u32 bit_width = table->serial_port.access_width;
 
                if (bit_width > ACPI_ACCESS_BIT_MAX) {
-                       pr_err("Unacceptable wide SPCR Access Width.  Defaulting to byte size\n");
+                       pr_err(FW_BUG "Unacceptable wide SPCR Access Width. Defaulting to byte size\n");
                        bit_width = ACPI_ACCESS_BIT_DEFAULT;
                }
                switch (ACPI_ACCESS_BIT_WIDTH((bit_width))) {
                default:
-                       pr_err("Unexpected SPCR Access Width.  Defaulting to byte size\n");
+                       pr_err(FW_BUG "Unexpected SPCR Access Width. Defaulting to byte size\n");
                        fallthrough;
                case 8:
                        iotype = "mmio";