OSDN Git Service

Merge "Check return from DeleteKey correctly." into oc-dev
authorShawn Willden <swillden@google.com>
Wed, 21 Jun 2017 00:54:07 +0000 (00:54 +0000)
committerandroid-build-merger <android-build-merger@google.com>
Wed, 21 Jun 2017 00:54:07 +0000 (00:54 +0000)
am: c4f859d1b5

Change-Id: Ib41e416ab79a56cddbaa61084645f626b4a3b22b

1  2 
keymaster/3.0/vts/functional/keymaster_hidl_hal_test.cpp

@@@ -540,17 -505,21 +540,24 @@@ class KeymasterHidlTest : public ::test
          return error;
      }
  
+     void CheckedDeleteKey(HidlBuf* key_blob, bool keep_key_blob = false) {
+         auto rc = DeleteKey(key_blob, keep_key_blob);
+         EXPECT_TRUE(rc == ErrorCode::OK || rc == ErrorCode::UNIMPLEMENTED);
+     }
+     void CheckedDeleteKey() { CheckedDeleteKey(&key_blob_); }
      ErrorCode GetCharacteristics(const HidlBuf& key_blob, const HidlBuf& client_id,
                                   const HidlBuf& app_data, KeyCharacteristics* key_characteristics) {
 -        ErrorCode error;
 -        keymaster_->getKeyCharacteristics(
 -            key_blob, client_id, app_data,
 -            [&](ErrorCode hidl_error, const KeyCharacteristics& hidl_key_characteristics) {
 -                error = hidl_error, *key_characteristics = hidl_key_characteristics;
 -            });
 +        ErrorCode error = ErrorCode::UNKNOWN_ERROR;
 +        EXPECT_TRUE(
 +            keymaster_
 +                ->getKeyCharacteristics(
 +                    key_blob, client_id, app_data,
 +                    [&](ErrorCode hidl_error, const KeyCharacteristics& hidl_key_characteristics) {
 +                        error = hidl_error, *key_characteristics = hidl_key_characteristics;
 +                    })
 +                .isOk());
          return error;
      }