OSDN Git Service

wlcore: use print_hex_dump_debug()
authorLuciano Coelho <coelho@ti.com>
Tue, 12 Mar 2013 15:04:01 +0000 (17:04 +0200)
committerLuciano Coelho <coelho@ti.com>
Mon, 25 Mar 2013 10:36:24 +0000 (12:36 +0200)
We were printing out all the hex dumps regardless of whether dynamic
debugging was enabled or not.  Now that print_hex_dump_debug() has
been implemented, we can use that instead.

Reported-by: Arik Nemtsov <arik@wizery.com>
Signed-off-by: Luciano Coelho <coelho@ti.com>
drivers/net/wireless/ti/wlcore/debug.h

index db4bf5a..0420bd4 100644 (file)
@@ -89,25 +89,24 @@ extern u32 wl12xx_debug_level;
        } while (0)
 #endif
 
-/* TODO: use pr_debug_hex_dump when it becomes available */
-#define wl1271_dump(level, prefix, buf, len)   \
-       do { \
-               if (level & wl12xx_debug_level) \
-                       print_hex_dump(KERN_DEBUG, DRIVER_PREFIX prefix, \
-                                      DUMP_PREFIX_OFFSET, 16, 1,       \
-                                      buf,                             \
-                                      min_t(size_t, len, DEBUG_DUMP_LIMIT), \
-                                      0);                              \
+#define wl1271_dump(level, prefix, buf, len)                                 \
+       do {                                                                  \
+               if (level & wl12xx_debug_level)                               \
+                       print_hex_dump_debug(DRIVER_PREFIX prefix,            \
+                                       DUMP_PREFIX_OFFSET, 16, 1,            \
+                                       buf,                                  \
+                                       min_t(size_t, len, DEBUG_DUMP_LIMIT), \
+                                       0);                                   \
        } while (0)
 
-#define wl1271_dump_ascii(level, prefix, buf, len)     \
-       do { \
-               if (level & wl12xx_debug_level) \
-                       print_hex_dump(KERN_DEBUG, DRIVER_PREFIX prefix, \
-                                      DUMP_PREFIX_OFFSET, 16, 1,       \
-                                      buf,                             \
-                                      min_t(size_t, len, DEBUG_DUMP_LIMIT), \
-                                      true);                           \
+#define wl1271_dump_ascii(level, prefix, buf, len)                           \
+       do {                                                                  \
+               if (level & wl12xx_debug_level)                               \
+                       print_hex_dump_debug(DRIVER_PREFIX prefix,            \
+                                       DUMP_PREFIX_OFFSET, 16, 1,            \
+                                       buf,                                  \
+                                       min_t(size_t, len, DEBUG_DUMP_LIMIT), \
+                                       true);                                \
        } while (0)
 
 #endif /* __DEBUG_H__ */