OSDN Git Service

scftorture: Account for weight_resched when checking for all zeroes
authorPaul E. McKenney <paulmck@kernel.org>
Tue, 13 Jul 2021 22:13:56 +0000 (15:13 -0700)
committerPaul E. McKenney <paulmck@kernel.org>
Thu, 16 Sep 2021 17:27:48 +0000 (10:27 -0700)
The "all zero weights makes no sense" error is emitted even when
scftorture.weight_resched is non-zero because it was left out of
the enclosing "if" condition.  This commit adds it in.

Fixes: 1ac78b49d61d4 ("scftorture: Add an alternative IPI vector")
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
kernel/scftorture.c

index 31b458b..74348ab 100644 (file)
@@ -583,8 +583,8 @@ static int __init scf_torture_init(void)
                if (weight_all_wait == -1)
                        weight_all_wait1 = 0;
        }
-       if (weight_single1 == 0 && weight_single_rpc1 == 0 && weight_single_wait1 == 0 &&
-           weight_many1 == 0 && weight_many_wait1 == 0 &&
+       if (weight_resched1 == 0 && weight_single1 == 0 && weight_single_rpc1 == 0 &&
+           weight_single_wait1 == 0 && weight_many1 == 0 && weight_many_wait1 == 0 &&
            weight_all1 == 0 && weight_all_wait1 == 0) {
                VERBOSE_SCFTORTOUT_ERRSTRING("all zero weights makes no sense");
                firsterr = -EINVAL;