OSDN Git Service

block: avoid to break XEN by multi-page bvec
authorMing Lei <ming.lei@redhat.com>
Sun, 17 Mar 2019 10:01:04 +0000 (18:01 +0800)
committerJens Axboe <axboe@kernel.dk>
Mon, 1 Apr 2019 18:11:17 +0000 (12:11 -0600)
XEN has special page merge requirement, see xen_biovec_phys_mergeable().
We can't merge pages into one bvec simply for XEN.

So move XEN's specific check on page merge into __bio_try_merge_page(),
then abvoid to break XEN by multi-page bvec.

Cc: ris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: xen-devel@lists.xenproject.org
Cc: Omar Sandoval <osandov@fb.com>
Cc: Christoph Hellwig <hch@lst.de>
Reviewed-by: Juergen Gross <jgross@suse.com>
Signed-off-by: Ming Lei <ming.lei@redhat.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/bio.c

index b64cedc..b2423e7 100644 (file)
@@ -776,6 +776,8 @@ bool __bio_try_merge_page(struct bio *bio, struct page *page,
 
                if (vec_end_addr + 1 != page_addr + off)
                        return false;
+               if (xen_domain() && !xen_biovec_phys_mergeable(bv, page))
+                       return false;
                if (same_page && (vec_end_addr & PAGE_MASK) != page_addr)
                        return false;