OSDN Git Service

s390/dis: Fix invalid array size
authorSyam Sidhardhan <syamsidhardh@gmail.com>
Sun, 24 Feb 2013 22:15:45 +0000 (03:45 +0530)
committerMartin Schwidefsky <schwidefsky@de.ibm.com>
Thu, 28 Feb 2013 08:37:09 +0000 (09:37 +0100)
We are using sizeof operator for an array given as function argument,
which is incorrect.

Signed-off-by: Syam Sidhardhan <s.syam@samsung.com>
Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
arch/s390/kernel/dis.c

index c50665f..3ad5e95 100644 (file)
@@ -1711,10 +1711,10 @@ int insn_to_mnemonic(unsigned char *instruction, char buf[8])
        if (!insn)
                return -ENOENT;
        if (insn->name[0] == '\0')
-               snprintf(buf, sizeof(buf), "%s",
+               snprintf(buf, 8, "%s",
                         long_insn_name[(int) insn->name[1]]);
        else
-               snprintf(buf, sizeof(buf), "%.5s", insn->name);
+               snprintf(buf, 8, "%.5s", insn->name);
        return 0;
 }
 EXPORT_SYMBOL_GPL(insn_to_mnemonic);