OSDN Git Service

net: stmmac: cleared __FPE_REMOVING bit in stmmac_fpe_start_wq()
authorMohammad Athari Bin Ismail <mohammad.athari.ismail@intel.com>
Thu, 29 Apr 2021 23:01:04 +0000 (07:01 +0800)
committerDavid S. Miller <davem@davemloft.net>
Fri, 30 Apr 2021 21:43:53 +0000 (14:43 -0700)
An issue found when network interface is down and up again, FPE handshake
fails to trigger. This is due to __FPE_REMOVING bit remains being set in
stmmac_fpe_stop_wq() but not cleared in stmmac_fpe_start_wq(). This
cause FPE workqueue task, stmmac_fpe_lp_task() not able to be executed.

To fix this, add clearing __FPE_REMOVING bit in stmmac_fpe_start_wq().

Fixes: 5a5586112b92 ("net: stmmac: support FPE link partner hand-shaking procedure")
Signed-off-by: Mohammad Athari Bin Ismail <mohammad.athari.ismail@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c

index a9a984c..e0b7eeb 100644 (file)
@@ -3180,6 +3180,7 @@ static int stmmac_fpe_start_wq(struct stmmac_priv *priv)
        char *name;
 
        clear_bit(__FPE_TASK_SCHED, &priv->fpe_task_state);
+       clear_bit(__FPE_REMOVING,  &priv->fpe_task_state);
 
        name = priv->wq_name;
        sprintf(name, "%s-fpe", priv->dev->name);