OSDN Git Service

skbuff: fix compilation warnings in skb_dump()
authorQian Cai <cai@lca.pw>
Tue, 16 Jul 2019 15:43:05 +0000 (11:43 -0400)
committerDavid S. Miller <davem@davemloft.net>
Tue, 16 Jul 2019 21:12:06 +0000 (14:12 -0700)
The commit 6413139dfc64 ("skbuff: increase verbosity when dumping skb
data") introduced a few compilation warnings.

net/core/skbuff.c:766:32: warning: format specifies type 'unsigned
short' but the argument has type 'unsigned int' [-Wformat]
                       level, sk->sk_family, sk->sk_type,
sk->sk_protocol);
                                             ^~~~~~~~~~~
net/core/skbuff.c:766:45: warning: format specifies type 'unsigned
short' but the argument has type 'unsigned int' [-Wformat]
                       level, sk->sk_family, sk->sk_type,
sk->sk_protocol);
^~~~~~~~~~~~~~~

Fix them by using the proper types.

Fixes: 6413139dfc64 ("skbuff: increase verbosity when dumping skb data")
Signed-off-by: Qian Cai <cai@lca.pw>
Reviewed-by: Nathan Chancellor <natechancellor@gmail.com>
Acked-by: Willem de Bruijn <willemb@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/core/skbuff.c

index 6f1e31f..0338820 100644 (file)
@@ -762,7 +762,7 @@ void skb_dump(const char *level, const struct sk_buff *skb, bool full_pkt)
                printk("%sdev name=%s feat=0x%pNF\n",
                       level, dev->name, &dev->features);
        if (sk)
-               printk("%ssk family=%hu type=%hu proto=%hu\n",
+               printk("%ssk family=%hu type=%u proto=%u\n",
                       level, sk->sk_family, sk->sk_type, sk->sk_protocol);
 
        if (full_pkt && headroom)