OSDN Git Service

PCI: dwc: Unindent dw_handle_msi_irq() loop
authorBjorn Helgaas <bhelgaas@google.com>
Thu, 16 Mar 2017 19:34:59 +0000 (14:34 -0500)
committerBjorn Helgaas <bhelgaas@google.com>
Tue, 4 Apr 2017 13:29:55 +0000 (08:29 -0500)
Use "continue" to skip rest of the loop when possible to save an indent
level.  No functional change intended.

Suggested-by: walter harms <wharms@bfs.de>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
drivers/pci/dwc/pcie-designware-host.c

index 5ba3349..6cdd41f 100644 (file)
@@ -63,17 +63,17 @@ irqreturn_t dw_handle_msi_irq(struct pcie_port *pp)
        for (i = 0; i < MAX_MSI_CTRLS; i++) {
                dw_pcie_rd_own_conf(pp, PCIE_MSI_INTR0_STATUS + i * 12, 4,
                                    (u32 *)&val);
-               if (val) {
-                       ret = IRQ_HANDLED;
-                       pos = 0;
-                       while ((pos = find_next_bit(&val, 32, pos)) != 32) {
-                               irq = irq_find_mapping(pp->irq_domain,
-                                                      i * 32 + pos);
-                               dw_pcie_wr_own_conf(pp, PCIE_MSI_INTR0_STATUS +
-                                                   i * 12, 4, 1 << pos);
-                               generic_handle_irq(irq);
-                               pos++;
-                       }
+               if (!val)
+                       continue;
+
+               ret = IRQ_HANDLED;
+               pos = 0;
+               while ((pos = find_next_bit(&val, 32, pos)) != 32) {
+                       irq = irq_find_mapping(pp->irq_domain, i * 32 + pos);
+                       dw_pcie_wr_own_conf(pp, PCIE_MSI_INTR0_STATUS + i * 12,
+                                           4, 1 << pos);
+                       generic_handle_irq(irq);
+                       pos++;
                }
        }