OSDN Git Service

RDMA/rxe: Remove useless rxe_init_device_param assignments
authorLeon Romanovsky <leonro@mellanox.com>
Sun, 20 Oct 2019 05:57:24 +0000 (08:57 +0300)
committerJason Gunthorpe <jgg@mellanox.com>
Thu, 24 Oct 2019 18:20:18 +0000 (15:20 -0300)
IB devices are allocated with kzalloc and don't need explicit zero
assignments for their parameters. It can be removed safely.

Link: https://lore.kernel.org/r/20191020055724.7410-1-leon@kernel.org
Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
drivers/infiniband/sw/rxe/rxe.c
drivers/infiniband/sw/rxe/rxe_param.h

index a8c11b5..0946a30 100644 (file)
@@ -77,12 +77,8 @@ static void rxe_init_device_param(struct rxe_dev *rxe)
 {
        rxe->max_inline_data                    = RXE_MAX_INLINE_DATA;
 
-       rxe->attr.fw_ver                        = RXE_FW_VER;
        rxe->attr.max_mr_size                   = RXE_MAX_MR_SIZE;
        rxe->attr.page_size_cap                 = RXE_PAGE_SIZE_CAP;
-       rxe->attr.vendor_id                     = RXE_VENDOR_ID;
-       rxe->attr.vendor_part_id                = RXE_VENDOR_PART_ID;
-       rxe->attr.hw_ver                        = RXE_HW_VER;
        rxe->attr.max_qp                        = RXE_MAX_QP;
        rxe->attr.max_qp_wr                     = RXE_MAX_QP_WR;
        rxe->attr.device_cap_flags              = RXE_DEVICE_CAP_FLAGS;
@@ -94,22 +90,13 @@ static void rxe_init_device_param(struct rxe_dev *rxe)
        rxe->attr.max_mr                        = RXE_MAX_MR;
        rxe->attr.max_pd                        = RXE_MAX_PD;
        rxe->attr.max_qp_rd_atom                = RXE_MAX_QP_RD_ATOM;
-       rxe->attr.max_ee_rd_atom                = RXE_MAX_EE_RD_ATOM;
        rxe->attr.max_res_rd_atom               = RXE_MAX_RES_RD_ATOM;
        rxe->attr.max_qp_init_rd_atom           = RXE_MAX_QP_INIT_RD_ATOM;
-       rxe->attr.max_ee_init_rd_atom           = RXE_MAX_EE_INIT_RD_ATOM;
        rxe->attr.atomic_cap                    = IB_ATOMIC_HCA;
-       rxe->attr.max_ee                        = RXE_MAX_EE;
-       rxe->attr.max_rdd                       = RXE_MAX_RDD;
-       rxe->attr.max_mw                        = RXE_MAX_MW;
-       rxe->attr.max_raw_ipv6_qp               = RXE_MAX_RAW_IPV6_QP;
-       rxe->attr.max_raw_ethy_qp               = RXE_MAX_RAW_ETHY_QP;
        rxe->attr.max_mcast_grp                 = RXE_MAX_MCAST_GRP;
        rxe->attr.max_mcast_qp_attach           = RXE_MAX_MCAST_QP_ATTACH;
        rxe->attr.max_total_mcast_qp_attach     = RXE_MAX_TOT_MCAST_QP_ATTACH;
        rxe->attr.max_ah                        = RXE_MAX_AH;
-       rxe->attr.max_fmr                       = RXE_MAX_FMR;
-       rxe->attr.max_map_per_fmr               = RXE_MAX_MAP_PER_FMR;
        rxe->attr.max_srq                       = RXE_MAX_SRQ;
        rxe->attr.max_srq_wr                    = RXE_MAX_SRQ_WR;
        rxe->attr.max_srq_sge                   = RXE_MAX_SRQ_SGE;
index fe52073..353c666 100644 (file)
@@ -60,12 +60,8 @@ static inline enum ib_mtu eth_mtu_int_to_enum(int mtu)
 
 /* default/initial rxe device parameter settings */
 enum rxe_device_param {
-       RXE_FW_VER                      = 0,
        RXE_MAX_MR_SIZE                 = -1ull,
        RXE_PAGE_SIZE_CAP               = 0xfffff000,
-       RXE_VENDOR_ID                   = 0,
-       RXE_VENDOR_PART_ID              = 0,
-       RXE_HW_VER                      = 0,
        RXE_MAX_QP                      = 0x10000,
        RXE_MAX_QP_WR                   = 0x4000,
        RXE_MAX_INLINE_DATA             = 400,
@@ -87,21 +83,12 @@ enum rxe_device_param {
        RXE_MAX_MR                      = 256 * 1024,
        RXE_MAX_PD                      = 0x7ffc,
        RXE_MAX_QP_RD_ATOM              = 128,
-       RXE_MAX_EE_RD_ATOM              = 0,
        RXE_MAX_RES_RD_ATOM             = 0x3f000,
        RXE_MAX_QP_INIT_RD_ATOM         = 128,
-       RXE_MAX_EE_INIT_RD_ATOM         = 0,
-       RXE_MAX_EE                      = 0,
-       RXE_MAX_RDD                     = 0,
-       RXE_MAX_MW                      = 0,
-       RXE_MAX_RAW_IPV6_QP             = 0,
-       RXE_MAX_RAW_ETHY_QP             = 0,
        RXE_MAX_MCAST_GRP               = 8192,
        RXE_MAX_MCAST_QP_ATTACH         = 56,
        RXE_MAX_TOT_MCAST_QP_ATTACH     = 0x70000,
        RXE_MAX_AH                      = 100,
-       RXE_MAX_FMR                     = 0,
-       RXE_MAX_MAP_PER_FMR             = 0,
        RXE_MAX_SRQ                     = 960,
        RXE_MAX_SRQ_WR                  = 0x4000,
        RXE_MIN_SRQ_WR                  = 1,