OSDN Git Service

drm/omap: ratelimit OCP error
authorTomi Valkeinen <tomi.valkeinen@ti.com>
Fri, 3 Mar 2017 10:15:39 +0000 (12:15 +0200)
committerTomi Valkeinen <tomi.valkeinen@ti.com>
Fri, 2 Jun 2017 07:57:21 +0000 (10:57 +0300)
Use dev_err_ratelimited() when an OCP error happens, to slightly easen
the flood.

Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
drivers/gpu/drm/omapdrm/omap_irq.c

index 7afe4b9..013b0bb 100644 (file)
@@ -182,12 +182,13 @@ static void omap_irq_fifo_underflow(struct omap_drm_private *priv,
        pr_cont("(0x%08x)\n", irqstatus);
 }
 
-static void omap_irq_ocp_error_handler(u32 irqstatus)
+static void omap_irq_ocp_error_handler(struct drm_device *dev,
+       u32 irqstatus)
 {
        if (!(irqstatus & DISPC_IRQ_OCP_ERR))
                return;
 
-       DRM_ERROR("OCP error\n");
+       dev_err_ratelimited(dev->dev, "OCP error\n");
 }
 
 static irqreturn_t omap_irq_handler(int irq, void *arg)
@@ -218,7 +219,7 @@ static irqreturn_t omap_irq_handler(int irq, void *arg)
                        omap_crtc_error_irq(crtc, irqstatus);
        }
 
-       omap_irq_ocp_error_handler(irqstatus);
+       omap_irq_ocp_error_handler(dev, irqstatus);
        omap_irq_fifo_underflow(priv, irqstatus);
 
        spin_lock_irqsave(&priv->wait_lock, flags);