OSDN Git Service

regulator: stm32-pwr: Fix return value check in stm32_pwr_regulator_probe()
authorWei Yongjun <weiyongjun1@huawei.com>
Wed, 17 Apr 2019 02:30:59 +0000 (02:30 +0000)
committerMark Brown <broonie@kernel.org>
Wed, 17 Apr 2019 16:33:45 +0000 (17:33 +0100)
In case of error, the function of_iomap() returns NULL pointer not
ERR_PTR(). The IS_ERR() test in the return value check should be
replaced with NULL test.

Fixes: 6cdae8173f67 ("regulator: Add support for stm32 power regulators")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/regulator/stm32-pwr.c

index 222d593..7b39a41 100644 (file)
@@ -140,9 +140,9 @@ static int stm32_pwr_regulator_probe(struct platform_device *pdev)
        int i, ret = 0;
 
        base = of_iomap(np, 0);
-       if (IS_ERR(base)) {
+       if (!base) {
                dev_err(&pdev->dev, "Unable to map IO memory\n");
-               return PTR_ERR(base);
+               return -ENOMEM;
        }
 
        config.dev = &pdev->dev;