OSDN Git Service

Staging: rtl8723bs: remove some dead code
authorDan Carpenter <dan.carpenter@oracle.com>
Mon, 4 Feb 2019 18:24:29 +0000 (21:24 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 7 Feb 2019 12:33:54 +0000 (13:33 +0100)
"psecnetwork" is the address of &psecuritypriv->sec_bss.  Since
->sec_bss isn't the first member of the struct that means that
"psecnetwork" can't be NULL.

We can just remove this dead code.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8723bs/core/rtw_cmd.c

index ea2c187..91520ca 100644 (file)
@@ -835,14 +835,6 @@ u8 rtw_joinbss_cmd(struct adapter  *padapter, struct wlan_network *pnetwork)
        }
 
        psecnetwork = (struct wlan_bssid_ex *)&psecuritypriv->sec_bss;
-       if (psecnetwork == NULL) {
-               kfree(pcmd);
-               res = _FAIL;
-
-               RT_TRACE(_module_rtl871x_cmd_c_, _drv_err_, ("rtw_joinbss_cmd :psecnetwork == NULL!!!\n"));
-
-               goto exit;
-       }
 
        memset(psecnetwork, 0, t_len);