OSDN Git Service

ALSA: sc6000: Fix incorrect sizeof operator
authorColin Ian King <colin.king@canonical.com>
Tue, 20 Jul 2021 16:17:07 +0000 (17:17 +0100)
committerTakashi Iwai <tiwai@suse.de>
Tue, 20 Jul 2021 16:22:29 +0000 (18:22 +0200)
Static analysis is warning that the sizeof being used is should be
of *vport and not vport. Although these are the same size it is not
a portable assumption to assume this is true for all cases.  Fix this
by using sizeof(*vport).

Addresses-Coverity: ("Sizeof not portable")
Fixes: 111601ff76e9 ("ALSA: sc6000: Allocate resources with device-managed APIs")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Link: https://lore.kernel.org/r/20210720161707.74197-1-colin.king@canonical.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/isa/sc6000.c

index 6236c4f..44c05b5 100644 (file)
@@ -552,7 +552,7 @@ static int snd_sc6000_probe(struct device *devptr, unsigned int dev)
 
 
        err = snd_devm_card_new(devptr, index[dev], id[dev], THIS_MODULE,
-                               sizeof(vport), &card);
+                               sizeof(*vport), &card);
        if (err < 0)
                return err;