OSDN Git Service

rtlwifi: rtl8723be: use true,false for bool variable large_cfo_hit
authorJason Yan <yanaijie@huawei.com>
Sat, 19 Sep 2020 07:44:37 +0000 (15:44 +0800)
committerKalle Valo <kvalo@codeaurora.org>
Tue, 22 Sep 2020 07:18:38 +0000 (10:18 +0300)
This addresses the following coccinelle warning:

drivers/net/wireless/realtek/rtlwifi/rtl8723be/dm.c:1155:27-47: WARNING:
Comparison of 0/1 to bool variable
drivers/net/wireless/realtek/rtlwifi/rtl8723be/dm.c:1156:3-23: WARNING:
Assignment of 0/1 to bool variable
drivers/net/wireless/realtek/rtlwifi/rtl8723be/dm.c:1159:3-23: WARNING:
Assignment of 0/1 to bool variable

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Jason Yan <yanaijie@huawei.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20200919074437.3459305-1-yanaijie@huawei.com
drivers/net/wireless/realtek/rtlwifi/rtl8723be/dm.c

index fbcff23..c3c990c 100644 (file)
@@ -1152,11 +1152,11 @@ static void rtl8723be_dm_dynamic_atc_switch(struct ieee80211_hw *hw)
                               (rtldm->cfo_ave_pre - cfo_ave) :
                               (cfo_ave - rtldm->cfo_ave_pre);
 
-               if (cfo_ave_diff > 20 && rtldm->large_cfo_hit == 0) {
-                       rtldm->large_cfo_hit = 1;
+               if (cfo_ave_diff > 20 && !rtldm->large_cfo_hit) {
+                       rtldm->large_cfo_hit = true;
                        return;
                } else
-                       rtldm->large_cfo_hit = 0;
+                       rtldm->large_cfo_hit = false;
 
                rtldm->cfo_ave_pre = cfo_ave;