OSDN Git Service

ASoC: soc-pcm: tidyup soc_pcm_pointer()'s delay update method
authorKuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Tue, 16 Nov 2021 07:45:34 +0000 (16:45 +0900)
committerMark Brown <broonie@kernel.org>
Mon, 29 Nov 2021 12:19:45 +0000 (12:19 +0000)
No driver directly updates runtime->delay in .pointer.
This patch cleanups its method.

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Link: https://lore.kernel.org/r/87zgq4wnkx.wl-kuninori.morimoto.gx@renesas.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/soc-pcm.c

index 493d231..3b44121 100644 (file)
@@ -1080,29 +1080,22 @@ start_err:
 /*
  * soc level wrapper for pointer callback
  * If cpu_dai, codec_dai, component driver has the delay callback, then
- * the runtime->delay will be updated accordingly.
+ * the runtime->delay will be updated via snd_soc_pcm_component/dai_delay().
  */
 static snd_pcm_uframes_t soc_pcm_pointer(struct snd_pcm_substream *substream)
 {
        struct snd_pcm_runtime *runtime = substream->runtime;
        snd_pcm_uframes_t offset = 0;
-       snd_pcm_sframes_t delay = 0;
        snd_pcm_sframes_t codec_delay = 0;
        snd_pcm_sframes_t cpu_delay = 0;
 
-       /* clearing the previous total delay */
-       runtime->delay = 0;
-
        offset = snd_soc_pcm_component_pointer(substream);
 
-       /* base delay if assigned in pointer callback */
-       delay = runtime->delay;
-
        /* should be called *after* snd_soc_pcm_component_pointer() */
        snd_soc_pcm_dai_delay(substream, &cpu_delay, &codec_delay);
        snd_soc_pcm_component_delay(substream, &cpu_delay, &codec_delay);
 
-       runtime->delay = delay + cpu_delay + codec_delay;
+       runtime->delay = cpu_delay + codec_delay;
 
        return offset;
 }