OSDN Git Service

media: mtk-vcodec: vdec: fix incorrect pointer dereference
authorYunfei Dong <yunfei.dong@mediatek.com>
Fri, 6 Sep 2019 11:55:01 +0000 (08:55 -0300)
committerMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Tue, 1 Oct 2019 19:44:57 +0000 (16:44 -0300)
mtk_q_data::fmt is actually a pointer and must be dereferenced as such.
This went under the radar because mtk_v4l2_debug() evaluates to nothing
unless DEBUG is defined.

[acourbot: split into its own commit]

Signed-off-by: Yunfei Dong <yunfei.dong@mediatek.com>
Signed-off-by: Alexandre Courbot <acourbot@chromium.org>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c

index 26a55c3..653f111 100644 (file)
@@ -284,7 +284,7 @@ static void mtk_vdec_update_fmt(struct mtk_vcodec_ctx *ctx,
                fmt = &mtk_video_formats[k];
                if (fmt->fourcc == pixelformat) {
                        mtk_v4l2_debug(1, "Update cap fourcc(%d -> %d)",
-                               dst_q_data->fmt.fourcc, pixelformat);
+                               dst_q_data->fmt->fourcc, pixelformat);
                        dst_q_data->fmt = fmt;
                        return;
                }