OSDN Git Service

Drivers: hv: vmus: Fix the check for return value from kmsg get dump buffer
authorSunil Muthuswamy <sunilmut@microsoft.com>
Sat, 28 Jul 2018 21:58:45 +0000 (21:58 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 29 Jul 2018 06:09:56 +0000 (08:09 +0200)
The code to support panic control message was checking the return was
checking the return value from kmsg_dump_get_buffer as error value, which
is not what the routine returns. This fixes it.

Fixes: 81b18bce48af ("Drivers: HV: Send one page worth of kmsg dump over Hyper-V during panic")

Signed-off-by: Sunil Muthuswamy <sunilmut@microsoft.com>
Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/hv/vmbus_drv.c

index 05e3728..a7f33c1 100644 (file)
@@ -1047,13 +1047,10 @@ static void hv_kmsg_dump(struct kmsg_dumper *dumper,
         * Write dump contents to the page. No need to synchronize; panic should
         * be single-threaded.
         */
-       if (!kmsg_dump_get_buffer(dumper, true, hv_panic_page,
-                                 PAGE_SIZE, &bytes_written)) {
-               pr_err("Hyper-V: Unable to get kmsg data for panic\n");
-               return;
-       }
-
-       hyperv_report_panic_msg(panic_pa, bytes_written);
+       kmsg_dump_get_buffer(dumper, true, hv_panic_page, PAGE_SIZE,
+                            &bytes_written);
+       if (bytes_written)
+               hyperv_report_panic_msg(panic_pa, bytes_written);
 }
 
 static struct kmsg_dumper hv_kmsg_dumper = {