OSDN Git Service

drm/bochs: drop unused gpu_addr arg from bochs_bo_pin()
authorGerd Hoffmann <kraxel@redhat.com>
Fri, 11 Jan 2019 05:37:47 +0000 (06:37 +0100)
committerGerd Hoffmann <kraxel@redhat.com>
Mon, 14 Jan 2019 07:39:14 +0000 (08:39 +0100)
It's always NULL, so just remove it.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: http://patchwork.freedesktop.org/patch/msgid/20190111053752.4004-12-kraxel@redhat.com
drivers/gpu/drm/bochs/bochs.h
drivers/gpu/drm/bochs/bochs_fbdev.c
drivers/gpu/drm/bochs/bochs_kms.c
drivers/gpu/drm/bochs/bochs_mm.c

index 4dc1b63..d0d474e 100644 (file)
@@ -142,7 +142,7 @@ int bochs_dumb_create(struct drm_file *file, struct drm_device *dev,
 int bochs_dumb_mmap_offset(struct drm_file *file, struct drm_device *dev,
                           uint32_t handle, uint64_t *offset);
 
-int bochs_bo_pin(struct bochs_bo *bo, u32 pl_flag, u64 *gpu_addr);
+int bochs_bo_pin(struct bochs_bo *bo, u32 pl_flag);
 int bochs_bo_unpin(struct bochs_bo *bo);
 
 /* bochs_kms.c */
index d9f3d42..92feb81 100644 (file)
@@ -81,7 +81,7 @@ static int bochsfb_create(struct drm_fb_helper *helper,
        if (ret)
                return ret;
 
-       ret = bochs_bo_pin(bo, TTM_PL_FLAG_VRAM, NULL);
+       ret = bochs_bo_pin(bo, TTM_PL_FLAG_VRAM);
        if (ret) {
                DRM_ERROR("failed to pin fbcon\n");
                ttm_bo_unreserve(&bo->bo);
index 5b7e1a7..f663c54 100644 (file)
@@ -101,7 +101,7 @@ static int bochs_plane_prepare_fb(struct drm_plane *plane,
        ret = ttm_bo_reserve(&bo->bo, true, false, NULL);
        if (ret)
                return ret;
-       ret = bochs_bo_pin(bo, TTM_PL_FLAG_VRAM, NULL);
+       ret = bochs_bo_pin(bo, TTM_PL_FLAG_VRAM);
        ttm_bo_unreserve(&bo->bo);
        return ret;
 }
index 0980411..5a0e092 100644 (file)
@@ -210,20 +210,13 @@ static void bochs_ttm_placement(struct bochs_bo *bo, int domain)
        bo->placement.num_busy_placement = c;
 }
 
-static inline u64 bochs_bo_gpu_offset(struct bochs_bo *bo)
-{
-       return bo->bo.offset;
-}
-
-int bochs_bo_pin(struct bochs_bo *bo, u32 pl_flag, u64 *gpu_addr)
+int bochs_bo_pin(struct bochs_bo *bo, u32 pl_flag)
 {
        struct ttm_operation_ctx ctx = { false, false };
        int i, ret;
 
        if (bo->pin_count) {
                bo->pin_count++;
-               if (gpu_addr)
-                       *gpu_addr = bochs_bo_gpu_offset(bo);
                return 0;
        }
 
@@ -235,8 +228,6 @@ int bochs_bo_pin(struct bochs_bo *bo, u32 pl_flag, u64 *gpu_addr)
                return ret;
 
        bo->pin_count = 1;
-       if (gpu_addr)
-               *gpu_addr = bochs_bo_gpu_offset(bo);
        return 0;
 }