OSDN Git Service

block: mtip32xx: don't touch q->queue_hw_ctx
authorMing Lei <ming.lei@redhat.com>
Tue, 8 Mar 2022 07:32:17 +0000 (15:32 +0800)
committerJens Axboe <axboe@kernel.dk>
Wed, 9 Mar 2022 00:57:19 +0000 (17:57 -0700)
q->queue_hw_ctx is really one blk-mq internal structure for retrieving
hctx via its index, not supposed to be used by drivers. Meantime drivers
can get the tags structure easily from tagset.

Reviewed-by: Hannes Reinecke <hare@suse.de>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Ming Lei <ming.lei@redhat.com>
Link: https://lore.kernel.org/r/20220308073219.91173-5-ming.lei@redhat.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/block/mtip32xx/mtip32xx.c

index cba9568..2d43ab5 100644 (file)
@@ -160,9 +160,7 @@ static bool mtip_check_surprise_removal(struct driver_data *dd)
 static struct mtip_cmd *mtip_cmd_from_tag(struct driver_data *dd,
                                          unsigned int tag)
 {
-       struct blk_mq_hw_ctx *hctx = dd->queue->queue_hw_ctx[0];
-
-       return blk_mq_rq_to_pdu(blk_mq_tag_to_rq(hctx->tags, tag));
+       return blk_mq_rq_to_pdu(blk_mq_tag_to_rq(dd->tags.tags[0], tag));
 }
 
 /*