OSDN Git Service

media: saa7146: fix error return from master_xfer
authorPeter Rosin <peda@axentia.se>
Wed, 9 May 2018 19:48:07 +0000 (15:48 -0400)
committerMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Fri, 11 May 2018 15:30:57 +0000 (11:30 -0400)
Returning -1 (-EPERM) is not appropriate here, go with -EIO.

Signed-off-by: Peter Rosin <peda@axentia.se>
Signed-off-by: Hans Verkuil <hansverk@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
drivers/media/common/saa7146/saa7146_i2c.c

index f9e099d..3feddc5 100644 (file)
@@ -308,7 +308,7 @@ static int saa7146_i2c_transfer(struct saa7146_dev *dev, const struct i2c_msg *m
        /* prepare the message(s), get number of u32s to transfer */
        count = saa7146_i2c_msg_prepare(msgs, num, buffer);
        if ( 0 > count ) {
-               err = -1;
+               err = -EIO;
                goto out;
        }
 
@@ -360,7 +360,7 @@ static int saa7146_i2c_transfer(struct saa7146_dev *dev, const struct i2c_msg *m
        /* if any things had to be read, get the results */
        if ( 0 != saa7146_i2c_msg_cleanup(msgs, num, buffer)) {
                DEB_I2C("could not cleanup i2c-message\n");
-               err = -1;
+               err = -EIO;
                goto out;
        }