OSDN Git Service

HSI: core: switch port event notifier from atomic to blocking
authorSebastian Reichel <sre@kernel.org>
Sat, 30 Apr 2016 16:08:06 +0000 (18:08 +0200)
committerSebastian Reichel <sre@kernel.org>
Mon, 27 Jun 2016 22:38:53 +0000 (00:38 +0200)
port events should be sent from process context after
irq_safe runtime pm flag is removed in omap-ssi.

Signed-off-By: Sebastian Reichel <sre@kernel.org>
Tested-by: Pavel Machek <pavel@ucw.cz>
drivers/hsi/hsi_core.c
include/linux/hsi/hsi.h

index d7ce07a..c2a2a97 100644 (file)
@@ -507,7 +507,7 @@ struct hsi_controller *hsi_alloc_controller(unsigned int n_ports, gfp_t flags)
                port[i]->stop_tx = hsi_dummy_cl;
                port[i]->release = hsi_dummy_cl;
                mutex_init(&port[i]->lock);
-               ATOMIC_INIT_NOTIFIER_HEAD(&port[i]->n_head);
+               BLOCKING_INIT_NOTIFIER_HEAD(&port[i]->n_head);
                dev_set_name(&port[i]->device, "port%d", i);
                hsi->port[i]->device.release = hsi_port_release;
                device_initialize(&hsi->port[i]->device);
@@ -689,7 +689,7 @@ int hsi_register_port_event(struct hsi_client *cl,
        cl->ehandler = handler;
        cl->nb.notifier_call = hsi_event_notifier_call;
 
-       return atomic_notifier_chain_register(&port->n_head, &cl->nb);
+       return blocking_notifier_chain_register(&port->n_head, &cl->nb);
 }
 EXPORT_SYMBOL_GPL(hsi_register_port_event);
 
@@ -709,7 +709,7 @@ int hsi_unregister_port_event(struct hsi_client *cl)
 
        WARN_ON(!hsi_port_claimed(cl));
 
-       err = atomic_notifier_chain_unregister(&port->n_head, &cl->nb);
+       err = blocking_notifier_chain_unregister(&port->n_head, &cl->nb);
        if (!err)
                cl->ehandler = NULL;
 
@@ -734,7 +734,7 @@ EXPORT_SYMBOL_GPL(hsi_unregister_port_event);
  */
 int hsi_event(struct hsi_port *port, unsigned long event)
 {
-       return atomic_notifier_call_chain(&port->n_head, event, NULL);
+       return blocking_notifier_call_chain(&port->n_head, event, NULL);
 }
 EXPORT_SYMBOL_GPL(hsi_event);
 
index 2790591..5740254 100644 (file)
@@ -246,7 +246,7 @@ struct hsi_port {
        int                             (*stop_tx)(struct hsi_client *cl);
        int                             (*release)(struct hsi_client *cl);
        /* private */
-       struct atomic_notifier_head     n_head;
+       struct blocking_notifier_head   n_head;
 };
 
 #define to_hsi_port(dev) container_of(dev, struct hsi_port, device)