OSDN Git Service

xen/gntdev-dmabuf: Ditch dummy map functions
authorDaniel Vetter <daniel.vetter@ffwll.ch>
Mon, 18 Nov 2019 10:35:34 +0000 (11:35 +0100)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Mon, 25 Nov 2019 21:36:52 +0000 (22:36 +0100)
There's no in-kernel users for the k(un)map stuff. And the mmap one is
actively harmful - return 0 and then _not_ actually mmaping can't end
well.

Acked-by: Sumit Semwal <sumit.semwal@linaro.org>
Reviewed-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: Juergen Gross <jgross@suse.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>
Cc: xen-devel@lists.xenproject.org
Link: https://patchwork.freedesktop.org/patch/msgid/20191118103536.17675-14-daniel.vetter@ffwll.ch
drivers/xen/gntdev-dmabuf.c

index 2c4f324..fe7bd69 100644 (file)
@@ -342,35 +342,12 @@ static void dmabuf_exp_ops_release(struct dma_buf *dma_buf)
        mutex_unlock(&priv->lock);
 }
 
-static void *dmabuf_exp_ops_kmap(struct dma_buf *dma_buf,
-                                unsigned long page_num)
-{
-       /* Not implemented. */
-       return NULL;
-}
-
-static void dmabuf_exp_ops_kunmap(struct dma_buf *dma_buf,
-                                 unsigned long page_num, void *addr)
-{
-       /* Not implemented. */
-}
-
-static int dmabuf_exp_ops_mmap(struct dma_buf *dma_buf,
-                              struct vm_area_struct *vma)
-{
-       /* Not implemented. */
-       return 0;
-}
-
 static const struct dma_buf_ops dmabuf_exp_ops =  {
        .attach = dmabuf_exp_ops_attach,
        .detach = dmabuf_exp_ops_detach,
        .map_dma_buf = dmabuf_exp_ops_map_dma_buf,
        .unmap_dma_buf = dmabuf_exp_ops_unmap_dma_buf,
        .release = dmabuf_exp_ops_release,
-       .map = dmabuf_exp_ops_kmap,
-       .unmap = dmabuf_exp_ops_kunmap,
-       .mmap = dmabuf_exp_ops_mmap,
 };
 
 struct gntdev_dmabuf_export_args {