OSDN Git Service

scsi: fas216: Use get_status_byte() to avoid using Linux-specific status codes
authorHannes Reinecke <hare@suse.de>
Tue, 27 Apr 2021 08:30:39 +0000 (10:30 +0200)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 1 Jun 2021 02:48:24 +0000 (22:48 -0400)
The driver should be using the standard SAM_STAT_ values, and not the
Linux-specific ones.

Link: https://lore.kernel.org/r/20210427083046.31620-34-hare@suse.de
Signed-off-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/arm/fas216.c

index 7e0e465..30ed3d2 100644 (file)
@@ -2060,15 +2060,15 @@ fas216_std_done(FAS216_Info *info, struct scsi_cmnd *SCpnt, unsigned int result)
         * If the command returned CHECK_CONDITION or COMMAND_TERMINATED
         * status, request the sense information.
         */
-       if (status_byte(SCpnt->result) == CHECK_CONDITION ||
-           status_byte(SCpnt->result) == COMMAND_TERMINATED)
+       if (get_status_byte(SCpnt) == SAM_STAT_CHECK_CONDITION ||
+           get_status_byte(SCpnt) == SAM_STAT_COMMAND_TERMINATED)
                goto request_sense;
 
        /*
         * If the command did not complete with GOOD status,
         * we are all done here.
         */
-       if (status_byte(SCpnt->result) != GOOD)
+       if (get_status_byte(SCpnt) != SAM_STAT_GOOD)
                goto done;
 
        /*