OSDN Git Service
(root)
/
tomoyo
/
tomoyo-test1.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
8b7a454
)
Fix another dereference before null check warning
author
Steve French
<smfrench@gmail.com>
Fri, 27 Mar 2015 06:00:06 +0000
(
01:00
-0500)
committer
Steve French
<smfrench@gmail.com>
Wed, 1 Apr 2015 05:01:47 +0000
(
00:01
-0500)
null tcon is not possible in these paths so
remove confusing null check
Reported by Coverity (CID 728519)
Signed-off-by: Steve French <smfrench@gmail.com>
Reviewed-by: Jeff Layton <jlayton@samba.org>
fs/cifs/smb2pdu.c
patch
|
blob
|
history
diff --git
a/fs/cifs/smb2pdu.c
b/fs/cifs/smb2pdu.c
index
78b329f
..
65cd7a8
100644
(file)
--- a/
fs/cifs/smb2pdu.c
+++ b/
fs/cifs/smb2pdu.c
@@
-1632,7
+1632,7
@@
SMB2_flush(const unsigned int xid, struct cifs_tcon *tcon, u64 persistent_fid,
rc = SendReceive2(xid, ses, iov, 1, &resp_buftype, 0);
- if (
(rc != 0) && tcon
)
+ if (
rc != 0
)
cifs_stats_fail_inc(tcon, SMB2_FLUSH_HE);
free_rsp_buf(resp_buftype, iov[0].iov_base);