OSDN Git Service

powerpc/cell/axon_msi: no need to check return value of debugfs_create functions
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 9 Feb 2020 10:59:00 +0000 (11:59 +0100)
committerMichael Ellerman <mpe@ellerman.id.au>
Wed, 4 Mar 2020 11:44:25 +0000 (22:44 +1100)
When calling debugfs functions, there is no need to ever check the
return value.  The function can work or not, but the code logic should
never do something different based on this.

Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20200209105901.1620958-5-gregkh@linuxfoundation.org
arch/powerpc/platforms/cell/axon_msi.c

index 57c4e0e..ca2555b 100644 (file)
@@ -480,10 +480,6 @@ void axon_msi_debug_setup(struct device_node *dn, struct axon_msic *msic)
 
        snprintf(name, sizeof(name), "msic_%d", of_node_to_nid(dn));
 
-       if (!debugfs_create_file(name, 0600, powerpc_debugfs_root,
-                                msic, &fops_msic)) {
-               pr_devel("axon_msi: debugfs_create_file failed!\n");
-               return;
-       }
+       debugfs_create_file(name, 0600, powerpc_debugfs_root, msic, &fops_msic);
 }
 #endif /* DEBUG */